Remove unused SHA-1 hash from UNPACK markers #46520
Open
+9
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In BootZipCopyAction and AbstractJarWriter, SHA-1 hash is calculated for stored entries requiring unpack and set as entry comment. However, the hash isn't used anywhere, just the marker prefix 'UNPACK:' is checked. This commit removes the unnecessary SHA-1 hash calculation which reads the file completely in memory, potentially three times in extreme cases. Now the comment is simply set to 'UNPACK:' without any hash, improving performance. Fixes spring-projectsgh-46183 Signed-off-by: Hyunjoon Choi <[email protected]> Signed-off-by: academey <[email protected]>
academey
force-pushed
the
gh-46183-remove-unused-sha1-hash
branch
from
f22845d to
3518a8e
Compare
spring-projects-issues
added
the
status: waiting-for-triage
|
We should probably update the runtime side of things as well: The @academey please don't make any changes to the PR just yet, I'd like to discuss with the team first. |
wilkinsona
added
type: enhancement
wilkinsona
added
the
for: team-meeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unused SHA-1 hash calculation from UNPACK markers in the JAR/WAR packaging process.
Current behavior:
When creating executable JARs/WARs, Spring Boot calculates a SHA-1 hash for entries that require unpacking and appends it to the entry comment as
UNPACK:<hash>. However, this hash is never used - only theUNPACK:prefix is checked.Changes made:
StoredEntryPreparatorin bothBootZipCopyActionandAbstractJarWriterUNPACK:<sha1-hash>to simplyUNPACK:Performance improvement:
This eliminates unnecessary file reads during packaging. Previously, files could be read up to 3 times (CRC calculation, SHA-1 hash, and actual copying). Removing the hash calculation reduces I/O operations and memory usage, especially beneficial for large libraries.
Fixes #46183